Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update normalizr schema usage #11

Open
wants to merge 1 commit into
base: 26-normalizing-json-responses-with-normalizr
Choose a base branch
from
Open

update normalizr schema usage #11

wants to merge 1 commit into from

Conversation

icyasblue
Copy link

@matthewchung74
Copy link

@gaearon can you merge this pr? I was about to submit the PR myself when I saw @icyasblue already did it. I think it would help others down the road.

@matthewchung74
Copy link

also, i'd like to follow with another PR as well, since I believe FilterLink.js line 6 should be to={filter} instead of to={filter === 'all' ? '' : filter} since the later prevents filtering by all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icyasblue @matthewchung74