Fixes #913 - Fix/improve guide for Electron #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies for the delay. I wanted to see how the situation with electron-compile's HMR would develop before committing to a recommendation. And I had to come up with a good workflow myself. Because it was only after I submitted issue gaearon#913 that I had the fairly banal realization that one could simply view an Electron app like any other web app. And that maybe one should. Most people probably choose to use Electron because they are already familiar with JS. So they've probably already used webpack. Why introduce new tools that at least partly don't work as well as webpack does? But I left the reference to electron-compile in there because it is quite popular, it does require less configuration and some people have argued that webpack should not be used with Electron. (Although they possibly overlook the fact that parse time may still play a role even when a big project is loaded directly from one's hard drive...)
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 31 31
Lines 802 802
Branches 189 189
=======================================
Hits 695 695
Misses 89 89
Partials 18 18Continue to review full report at Codecov.
|
gregberge
requested changes
May 28, 2018
README.md
Outdated
| ```js | ||
| enableLiveReload({ strategy: 'react-hmr' }) | ||
| ``` | ||
| One way of doing this with Electron is to simply use webpack like any web-based project might do and the general guide above describes. See also [this example Electron app](https://github.com/s-h-a-d-o-w/rhl-electron-quick-start) |
README.md
Outdated
|
|
||
| See a [complete example](https://github.com/rllola/hmr-example-issue-2/blob/master/src/index.js). | ||
| A webpack-less way of doing it to use `electron-compile` (which is also used by `electron-forge`) - see [this example](https://github.com/rllola/hmr-example-issue-2). While it requires less configuration, something to keep in mind is that `electron-compile`'s HMR will always reload all modules, regardless of what was actually edited. |
There was a problem hiding this comment.
Webpack-less*
- Links on electron-compile and electron-forge
|
Hm... I didn't see that and you're obviously right for consistency's sake. However, I would like to point out that the official way of spelling "webpack" is indeed with a lower-case w in the beginning: https://webpack.js.org/concepts/ |
|
@s-h-a-d-o-w you are right, let's go for "webpack"! |
|
Never too late 👍 |
|
As far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the delay. I wanted to see how the situation with electron-compile's HMR would develop before committing to a recommendation.
And I had to come up with a good workflow myself. Because it was only after I submitted issue #913 that I had the fairly banal realization that one could simply view an Electron app like any other web app. And that maybe one should. Most people probably choose to use Electron because they are already familiar with JS. So they've probably already used webpack. Why introduce new tools that at least partly don't work as well as webpack does?
But I left the reference to electron-compile in there because it is quite popular, it does require less configuration and some people have argued that webpack should not be used with Electron. (Although they possibly overlook the fact that parse time may still play a role even when a big project is loaded directly from one's hard drive...)