need moar this #972
Merged
need moar this #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
approved these changes
May 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 89.06% 90.01% +0.94%
==========================================
Files 30 30
Lines 741 801 +60
Branches 168 182 +14
==========================================
+ Hits 660 721 +61
+ Misses 67 66 -1
Partials 14 14
Continue to review full report at Codecov.
|
|
@timneutkens - could you try master branch? Is this the last fix we all need? |
|
Solves the issue we had. |
|
Ok, lets wait for #975 and then release a new version. |
|
Same issue here with this5 - when will this fix be released? |
|
@Kaishiyoku - hold my beer |
|
version 4.2.0 - released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding more this for #969