Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This is a major milestone for v5 and removes one of the biggest RHL's sideeffect type comparison - #304
State before
hot-loader/react-dom
introduces controller type comparison. We injected a few things toreact-dom
hotCleanup
, to cleanup hooks renderinghotRenderWithHooks
, to be able to render hooks inhotReplacementRender
setHotElementComparator
, to control type comparison, injected intoreconcileSingleElement
New
This PR adds one more injection
setHotTypeResolver
injected intocreateFiberFromTypeAndProps
How it works
<Type/>.type==Type
both forFC
(worked before), and now forClasses
type
but aproxy
hotElementComparator
, which comparesfiber
node withelement
now comparesproxy
with the original type, and have towrap
element to perform comparison.This is a replacement for #1138
Left to do
I recon the second issue could be if not skipped, then deprecated due to the hooks.