-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation clarification around code splitting #1368
Comments
There was (and some issues says still is) an issue, which would be better described as I could see my update only after anther update.
It could be caused by different reasons, but in terms of code splitting it was due the non-instant effect from There was a special logic to handle So, if RHL detects that something was updated after update just finished - it updates everything again. This change initial process:
However, code splitting library still should detect HMR and call the importer again. Not all are doing that. I hope now you have enought context to reword this sentence. |
I think so. Lemme submit a PR and see if I've got it. Thank you! |
It would be nice if we could disable the warning, is this possible? |
Or "report it once"? |
Well, the docs say "The warning is informational - it is a notice that this tail update logic is triggered, and does not indicate a problem in the configuration or usage of react-hot-loader.". I have a team of developers working with me, I'm managing the SSR/HMR setup. I don't think every developer should need to know about the inner works of a HMR. Ideally, I can set If this makes sense, I can try and see if I can implement the change. |
The idea being that if you're specifying the behavior, it shouldn't tell you that it's doing it? That makes sense to me. |
Sounds right |
Opened #1386 where I'll implement this! |
Looking at this section in under the code splitting header:
I don't understand what this paragraph means. When does the warning show? Does it mean that something is wrong, or does it just indicate that a component on the other side of a code-splitting boundary has been updated?
I'm happy to submit an update to this section once I feel like I understand it.
The text was updated successfully, but these errors were encountered: