Rework docs around code splitting #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theKashey
reviewed
Oct 28, 2019
README.md
Outdated
|
|
||
| <!-- TODO: make sure that these are all currently compatible --> |
There was a problem hiding this comment.
Well, should we add React.lazy?
theKashey
reviewed
Oct 28, 2019
README.md
Outdated
|
|
||
| <!-- TODO: make sure that these are all currently compatible --> | ||
| * [Loadable Components](https://github.com/smooth-code/loadable-components/) |
There was a problem hiding this comment.
There is a test in the examples. It's a bit complicated, as long as you can test only one library in a single point of time (or they would help each other to update).
Probably the last version of loadable components is not reload-friendly.
theKashey
reviewed
Oct 28, 2019
README.md
Outdated
| If you use a non-yet-friendly library, like [react-async-component](github.com/ctrlplusb/react-async-component) you have to mark all your "loaded components" as _hot-exported_: | ||
| If you use a not-yet-friendly library, like [react-async-component](github.com/ctrlplusb/react-async-component), | ||
| or are having problems with hot reloading failing to reload code-split components, | ||
| you can manually mark the components at the code-split boundaries. |
There was a problem hiding this comment.
you can manually mark the components as hot (below the code-split boundary)
|
Looking much better! |
|
Sweet. I also tweaked those bits. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368
Motivation
I was having a hard time grokking the docs around code splitting, so I opened #1386. @theKashey helped me understand what was going on, and I wanted to update and clarify the docs if I could.
Changes