-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that react-hot-loader/babel should now be used in production too #1104
Comments
@edmorley Good idea. Are you willing to do this by your self? |
I might have a chance to open a PR in a week or two, but quite a few other things pending at the moment :-) |
I don't exactly get why is it recommended to have |
|
@theKashey can you please detail that a bit more? How do you know that it disables webpack module concatenation? Also, did you mean that happens when we use the plugin in production config (i.e. in babelrc setting "react-hot-loader/babel" in the general section, and not just in env.development.plugins)? |
@DinerIsmail - see #1080 |
In #1081 the RHL Babel plugin for when
process.env.NODE_ENV
isproduction
was changed from a no-op to a plugin that removes thehot()
wrapper.This means it's now recommended to not only use the plugin in development, but in any production configs too.
As such, it would be good to update the docs to say that
react-hot-loader/babel
should be used in all environments. eg here:https://github.com/gaearon/react-hot-loader#getting-started
https://github.com/gaearon/react-hot-loader#migrating-from-create-react-app
CC @smelukov
The text was updated successfully, but these errors were encountered: