Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Babel 6 & Rewrite #50

Merged
merged 15 commits into from
Dec 8, 2015
Merged

Babel 6 & Rewrite #50

merged 15 commits into from
Dec 8, 2015

Conversation

jamiebuilds
Copy link
Collaborator

I had a lot of time to kill on an airplane today and I decided to completely rewrite this plugin.

  • Babel 6 (Babel 6 #46)
  • Removed internal use of decorators (re)
  • @gaearon I'm not sure what you meant by import shadowing bug (re)
  • Didn't add support for functional components, I think there's more that needs to be discussed separately. I already have a branch that does it in a kinda hacky way (re)

Note: This plugin easily could have been upgraded from Babel 5 to Babel 6 without such invasive changes, I just went HAM on this plugin.

@jamiebuilds
Copy link
Collaborator Author

/.../options-custom-super-classes/actual.js: patterns.find is not a function

😢

@gaearon
Copy link
Owner

gaearon commented Nov 24, 2015

Awesome, thank you!
I'll review as soon as I settle in London.

<3

@phaistonian
Copy link

So ...are we there yet?:)

@gaearon
Copy link
Owner

gaearon commented Nov 27, 2015

This is my last week before starting a new job.
Give me some time away from computers please. 😉
I'll review soon.

@phaistonian
Copy link

@gaearon Oh, best of luck in this next adventure.

I read somewhere that you moved to London and, if that's the case, I am so envy.

It's a great place to be, work and live.

Enjoy :)

@thom4parisot
Copy link

@phaistonian I confirm London is cool ;-) @gaearon best of luck for your move. if you need any help or tips, let me know :-)

@jamiebuilds
Copy link
Collaborator Author

@phaistonian @oncletom This is not the best place for conversation, head to twitter

@steida steida mentioned this pull request Nov 28, 2015
3 tasks
@joshblack
Copy link
Collaborator

RE: .find is not a function, do you want to leverage Array#find or just include a polyfill so older versions of node will still work? Noticed it's used here as well.

I know the Relay team just made this change with their plugin and wanted to see if this project should do the same as well.

@jamiebuilds
Copy link
Collaborator Author

Yeah, I need to do that

@thebigredgeek
Copy link

Bump? Any update on this? Need it badly

@jamiebuilds
Copy link
Collaborator Author

Okay, so since this is one of the most used Babel plugins outside of the project itself and is currently blocking a lot of users from the React community from using Babel 6, I've asked @gaearon to add me to the project so that I could publish everything and fix things as issues arise.

The plan is going to be to publish a prerelease version this evening and ask everyone to test things out, then depending on the issues that arise we'll publish the final major version sometime in the next few days.

I'm going to merge now, if you notice anything that needs updating in the repo please make a PR. I'll also go through it again myself this evening.

Also: I just removed the Symbol to support Node v0.10.

jamiebuilds added a commit that referenced this pull request Dec 8, 2015
@jamiebuilds jamiebuilds merged commit ea61f27 into gaearon:master Dec 8, 2015
@jamiebuilds jamiebuilds deleted the tjk/babel-6 branch December 8, 2015 17:10
@dvdzkwsk
Copy link

dvdzkwsk commented Dec 8, 2015

Hooray! Thanks so much @thejameskyle and @gaearon!

@balthazar
Copy link

❤️ @thejameskyle @gaearon

@jhen0409
Copy link

jhen0409 commented Dec 8, 2015

👍 👍 👍

@STRML
Copy link
Contributor

STRML commented Dec 8, 2015

Nice work guys.

@bpierre
Copy link

bpierre commented Dec 8, 2015

Thank you!

@chentsulin
Copy link

Awesome 👍

@weblancaster
Copy link

Great work @thejameskyle

@leandrooriente
Copy link

Great!

@bluedaniel
Copy link

Thanks 😄

@Bertg
Copy link

Bertg commented Dec 8, 2015

Extatic

@mathieumg
Copy link

🎉

@lomadurov
Copy link

@weblancaster
Copy link

It just need to be released though haha (so we won't install from master).

@bjrmatos
Copy link

bjrmatos commented Dec 8, 2015

@thejameskyle thnk you so much for adding support for node 0.10.x :)

@lusentis
Copy link

lusentis commented Dec 8, 2015

Thank you!

@trueter
Copy link

trueter commented Dec 8, 2015

Much appreciated!

@r-park
Copy link

r-park commented Dec 8, 2015

Thanks! 😃

@LeoLeBras
Copy link

Thank you !!! :)

@moeriki
Copy link

moeriki commented Dec 8, 2015

Thanks all! This is the most amazing feature to have!

@carloscuatin
Copy link

thanks :) !

Repository owner locked and limited conversation to collaborators Dec 8, 2015
@jamiebuilds
Copy link
Collaborator Author

Thanks for the thanks-es, but these emails are driving me crazy

@jamiebuilds
Copy link
Collaborator Author

Just published [email protected] please check it out in your projects and make sure it works.

For an example of how to set it up in Babel 6 check out this repo: https://github.com/thejameskyle/babel-setup-react-transform

@jamiebuilds
Copy link
Collaborator Author

Note: This prerelease is not tagged as latest, you will have to run either:

$ npm install --save-dev babel-plugin-react-transform@beta

or

$ npm install --save-dev [email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.