Fix SLF4J conflict with Kotlin scripting, default log level #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #178, logging was changed to SLF4J and logback-classic. To keep it possible to set the log level via environment variables (
Config.logLevel
/DEVELOCITY_API_LOG_LEVEL
), a small hack was in place. Kotlin scripts, which haveslf4j-simple
in the classpath by default, crashed due to this hack.Also, the default log level was 'info', but it was supposed to be 'off'.
slf4j-simple
instead with a simpler hack ✨ to set the log level from environment variables