-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httplib with OpenSSL mock support #215
Conversation
Aha! Now these builds tell me something I didn't know :)
Will fix in a while |
@gabrielfalcao there are two things to notice about the builds:
|
Any chance this will get merged? |
Conflicts: test-requirements.txt
Hi!
Your PR has test coverage but the travis build is breaking, I'd love to merge this as soon as the travis build is passing. Thoughts? |
@andresriancho This implementation won't work for python 3 since |
httpretty/core.py
Outdated
@@ -468,7 +490,28 @@ def fake_wrap_socket(s, *args, **kw): | |||
return s | |||
|
|||
|
|||
def create_fake_connection(address, timeout=socket._GLOBAL_DEFAULT_TIMEOUT, source_address=None): | |||
def fake_fileobject(s, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice
Done:
Running all functional tests (at least on my workstation) fails with some "port already in use" errors. What's that about? Any ideas on how to fix that? (it was a problem even before this patch)
I'm sending this PR with two main objectives:
1- Get travis to run all tests (maybe there we don't get those errors)
2- Get an initial review of the code/changes