Fixing the border to be just on the bottom #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found an issue with this solution, it's not supported with the dotted border |
|
Fixed the issue |
|
Hi @TNAJanssen, do you mind sharing a small demo about the issue that this PR is fixing? I'm not able to reproduce it on my end. https://snack.expo.dev/ makes it easy to share this type of small demos |
|
Once we merge this we can release v1.0.10 including this and #75 |
|
Hi @gabrieldonadel when can you release this? |
|
@TNAJanssen please provide a small demo about the issue that this PR is fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making sure the line is just on the bottom and not on the top, left and right.
How has this been tested?
On my own project
Screenshots