Skip to content

Commit

Permalink
🐛 getting rid of str annotation for the command argument (#501)
Browse files Browse the repository at this point in the history
  • Loading branch information
kashyab12 authored Nov 15, 2023
1 parent e17e50a commit a46a133
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions python_on_whales/components/container/cli_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def diff(self) -> Dict[str, str]:

def execute(
self,
command: Union[str, List[str]],
command: List[str],
detach: bool = False,
envs: Dict[str, str] = {},
env_files: Union[ValidPath, List[ValidPath]] = [],
Expand Down Expand Up @@ -838,7 +838,7 @@ def diff(self, container: ValidContainer) -> Dict[str, str]:
def execute(
self,
container: ValidContainer,
command: Union[str, List[str]],
command: List[str],
detach: bool = False,
envs: Dict[str, str] = {},
env_files: Union[ValidPath, List[ValidPath]] = [],
Expand Down
2 changes: 1 addition & 1 deletion python_on_whales/components/service/cli_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class ServiceCLI(DockerCLICaller):
def create(
self,
image: str,
command: Union[str, List[str], None],
command: Optional[List[str]],
cap_add: List[str] = [],
cap_drop: List[str] = [],
constraints: List[str] = [],
Expand Down

0 comments on commit a46a133

Please sign in to comment.