Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SimpleSDMLayers to v0.6.0 and DataFrames to v1.1.1 #29

Merged
merged 4 commits into from
May 18, 2021

Conversation

gabrieldansereau
Copy link
Owner

@gabrieldansereau gabrieldansereau commented May 14, 2021

Upgrading SimpleSDMLayers to v0.6.0 and DataFrames to v1.1.1.

TO-DO

  • Replace worldclim by SimpleSDMPredictor(WorldClim, BioClim, ...)
  • Fix DataFrame(matrix, :auto) calls

Except ones in archive/ and ones still using resolution="10.0" or something
Mostly fixing 'DataFrame(matrix, :auto)' and 'insertcols!(df, 1, :colname => values)'
@gabrieldansereau
Copy link
Owner Author

The upgrade is technically done, so I'll merge this.

However, I found the bug described in PoisotLab/SimpleSDMLayers.jl#99 while upgrading, which has actually been around for a while and breaks a few things here. Here's the details for each script. I'll fix them once the issue is closed.

  • 00c_preparation_landcover.jl: ❌ cannot combine the env layers as their dimensions are not the same, which blocks exporting distributions_env_full.csv. The file is still valid since the export hasn't been done in a while
  • 01_distributions.jl: ✅ current script is broken, but presence-absence only uses the dimensions from a WorldClim layer, so it can be worked around easily
  • 02_training_*.R: ✔️ should be fine as distributions_env_full.csv has not been updated :
  • 03_prediction: ✔️ no change
  • 04_analysis: ✔️ no change
  • 05_subareas:
    • NE-SW: ✔️ same dimensions
    • 3 extents: ❌ dimensions are different, which means the results will change a bit once the bug is fixed. Shouldn't change much though, as its only a difference of one row or column
  • 06_moving-window: ✔️ bah
  • 07_difference: ✔️ no change
  • 08_rarespecies: ✔️ same dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant