Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using spdlog with fmtlib 536cabd562831816450ce3f9e57d4da0777ffa9b gives me compile errors #3258

Closed
Vertexwahn opened this issue Nov 15, 2024 · 2 comments

Comments

@Vertexwahn
Copy link

I try to use fmtlib with commit hash 536cabd562831816450ce3f9e57d4da0777ffa9b (from Nov 15, 2024) when building spdlog (with commit hash 51a0deca2c825f1d4461655a18bb37d6df76646d from Nov 9, 2024) (I set the define SPDLOG_FMT_EXTERNAL)

I get the following compile error:

In file included from external/spdlog~/include/spdlog/spdlog.h:12,
                 from ./core/logging.hpp:44,
                 from core/platform.cpp:37:
external/spdlog~/include/spdlog/common.h:369:54: error: 'template<class T, class ... Args> fmt::v11::basic_string_view<Char> spdlog::details::to_string_view' redeclared as different kind of entity
  369 | inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {

If I use fmt version 11.0.2 everything compiles without errors.

@tt4g
Copy link
Contributor

tt4g commented Nov 15, 2024

Unreleased fmt is not supported yet. If the same error occurs after release, it will be fixed.

@Vertexwahn
Copy link
Author

Close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants