Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In fmt master, basic_format_string has moved from base.h to xchar.h #3202

Open
pratikpc opened this issue Sep 26, 2024 · 4 comments · May be fixed by #3277
Open

In fmt master, basic_format_string has moved from base.h to xchar.h #3202

pratikpc opened this issue Sep 26, 2024 · 4 comments · May be fixed by #3277

Comments

@pratikpc
Copy link

Took place in this commit

This change causes compile time errors due to:-

  1. Using SPDLOG_FMT_EXTERNAL and using fmt master
  2. spdlog/common needing basic_format_string without SPDLOG_USE_STD_FORMAT
    #ifndef SPDLOG_USE_STD_FORMAT
    template <typename T, typename... Args>
    inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {
    return fmt;
  3. xchar.h not being included due to absence of the specified definitions
    #if defined(SPDLOG_WCHAR_FILENAMES) || defined(SPDLOG_WCHAR_TO_UTF8_SUPPORT)
    #include <spdlog/fmt/xchar.h>
    #endif
@pratikpc
Copy link
Author

I solved it personally for myself by removing the ifdefs around the headers

@tt4g
Copy link
Contributor

tt4g commented Sep 26, 2024

This is a change that has not yet been released, so we will figure out how to address it after its release.

@Vertexwahn
Copy link

I run in exact the same issue -> #3258

@ahoarau
Copy link

ahoarau commented Nov 30, 2024

Same issue here (wrongly addressed in #3274)

@ahoarau ahoarau linked a pull request Nov 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants