Updated repo to remove Protocol Buffer schema, replacing it with Swag… #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger def as the canonical definition. * Removed Makefile (no longer needed) * Removed protobuf definition file
… now, but wanted to at least provide consistency
Merged
Minor service name change to align with [WES > title](https://github.com/ga4gh/workflow-execution-service-schemas/blob/7e553fdd740e6bf05952fc188c60145da9316e75/openapi/workflow_execution_service.swagger.yaml#L4)
|
@adamstruck is this PR good for you guys? |
adamstruck
approved these changes
Feb 19, 2019
|
Looks like things will be cleaned up further in #113 so I am fine with merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ger def as the canonical definition.
Starts on fixing issue #109
TO-DO: need to update the schema to fix operationId and other documentation. Will do that as a separate PR.