Bug fix: composite payload httpHeaders should be map[string]string instead of map[string][]string #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of map[string][]string Fixes Issue g8rswimmer#56 A drawback of this fix is, if the user passes in multiple values for a key, Salesforce would still return an error. Another possible fix is to change the type of Subrequester.HTTPHeaders from http.Header to map[string]string but we probably don't want to do that because callers may expect to be able to pass in a http.Header type for that field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #56
A drawback of this fix is, if the user passes in multiple values for a key, Salesforce would still return an error.
Another possible fix is to change the type of
Subrequester.HTTPHeadersfromhttp.Headertomap[string]stringbut we probably don't want to do that because callers may expect to be able to pass in ahttp.Headertype for that field.