-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor G3WObject
, Panel
and Component
classes
#574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raruto
changed the title
Refactor
Refactor Feb 19, 2024
Panel
and Component
classesG3WObject
, Panel
and Component
classes
@volterra79 please avoid rewriting |
@volterra79 🥲 sometimes using more specific descriptions would help others analyze/find your edits. |
Raruto
commented
Mar 8, 2024
… we need to close the previous one
…SearchPanel.vue" This reverts commit 456c0e4.
Raruto
added a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Apr 12, 2024
…3w-suite/g3w-client into refactor-panels-and-components
…3w-suite/g3w-client into refactor-panels-and-components
volterra79
approved these changes
Apr 19, 2024
wlorenzetti
pushed a commit
to g3w-suite/g3w-admin
that referenced
this pull request
Apr 22, 2024
* move shorten condition at top (if-else) * ternary assignment * alias: `field['input']` → `input` * reduce nesting * keep a focus on JSON response structure * comments * spacing * client g3w-suite/g3w-client@5bbe9ca * `widget_serializzer_data` → `w_data` * client g3w-suite/g3w-client@c08802c * fix `search_1n` * TODO * ✨ Client g3w-suite/g3w-client@c8f16e9 g3w-suite/g3w-client-plugin-editing@fccb0e6 * g3w-suite/g3w-client@b83cdad * g3w-suite/g3w-client@f797285 * move `layerid` into `WidgetSerializer` * 🐛 Client g3w-suite/g3w-client-plugin-editing@d03671e * g3w-suite/g3w-client@28435f2 * deprecate `G3W_CLIENT_SEARCH_ENDPOINT` * g3w-suite/g3w-client@ea6e5ac * attempt to fix client test * 🐛 Client g3w-suite/g3w-client-plugin-editing@dc37654 * remove initial `values` in within search config * g3w-suite/g3w-client#574 * tests * `blanktext` → `description` * g3w-suite/g3w-client@1f3a8d9 * 🐛 Client g3w-suite/g3w-client-plugin-editing@5211bee * g3w-suite/g3w-client@e108bcd * g3w-suite/g3w-client@9618ec2 * ✨ Client g3w-suite/g3w-client-plugin-editing@0375222 --------- Co-authored-by: volterra79 <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on g3w-suite/g3w-admin#787
Motivation
GUI
class #451)Abstract
gui/utils/barstack.js
intocore/g3w-barstack.js
gui/component/component.js
intocore/g3w-component.js
gui/panel.js
intocore/g3w-panel.js
component/g3w-catalog.js
component/g3w-changemapmenu.js
component/g3w-contentsviewer.js
component/g3w-form.js
component/g3w-map.js
component/g3w-metadata.js
component/g3w-print.js
component/g3w-projectsmenu.js
component/g3w-querybuilder.js
component/g3w-queryresults.js
component/g3w-relationspage.js
component/g3w-search.js
component/g3w-spatialbookmarks.js
component/g3w-tools.js
component/g3w-wms.js
search_endpoint = 'ows'
(until removal, the new default is:'api'
)Related to: #193