Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inputs and fields mixins #450

Open
wants to merge 166 commits into
base: dev
Choose a base branch
from
Open

Refactor inputs and fields mixins #450

wants to merge 166 commits into from

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jul 20, 2023 •
edited
Loading

Preparatory for: #393

List of changes

  • consolidate inputs and fields definitions into a single file:

    • delete folder src/app/gui/inputs/ (replaced by g3wInputMixin baseInputMixin)
    • delete folder src/app/gui/fields/ (replaced by fieldsMixin)
    • add new file src/mixins/g3w-input.js
    • refactor file src/mixins/fields.js

  • overall code formatting related to input and fields components, especially regarding:

    • refactor file src/components/InputG3W.vue
    • refactor file src/components/FieldG3W.vue
    • refactor file src/components/InputBase.vue
    • refactor file src/components/GlobalTabsNode.vue
    • refactor file src/components/QueryResults.vue
    • ...

Related to: #193

Raruto added 24 commits July 5, 2023 11:44
@Raruto
delete folder: src/app/gui/inputs/
442bb9d 
starts consolidating all files into a single file: `src/app/gui/inputs.js`
@Raruto
Merge branch 'dev' into refactor-inputs
3668cb4
@Raruto
remove parenthesis
4e3596a
@Raruto
spacing
3086d72
@Raruto
add console.assert
d75b466
@Raruto
Update gulpfile.js
9964fa7
@Raruto
remove src/app/gui/inputs.js
5d75dcb
@Raruto
template string
3630da9
@Raruto
rename file: mixins/base-inputs.js --> mixins/g3w-input.js
5b7838c
@Raruto
spacing
4455749
@Raruto
spacing
dcc1101
@Raruto
new factory method: `mixins/g3w-input::createInputService(type, optio…
6b727da 
…ns)`
@Raruto
comments
e5e7dc6
@Raruto
refactor and delete folder src/app/gui/fields/
f835618
@Raruto
Update form-inputs.js
2f4ca94
@Raruto
extra comma
cd0da23
@Raruto
update g3w-resize related components
945d2bf
@Raruto
remove class inheritance: picklayer
2efd115
@Raruto
update global resize components
f1c9f4e
@Raruto
code format
85bf5e8
@Raruto
vue warnings
b538b10
@Raruto
Update Relation.vue
e92bc42
@Raruto
Merge branch 'dev' into refactor-inputs-and-fields
65d833f
@Raruto
Merge branch 'dev' into refactor-inputs-and-fields
1269d64
@Raruto Raruto added the refactoring Anything which could result in a API change label Jul 20, 2023
@Raruto Raruto added this to the v3.9 milestone Jul 20, 2023
@Raruto Raruto mentioned this pull request Jul 20, 2023
Closed
@volterra79 volterra79 modified the milestones: v3.9, v4.0 Nov 6, 2023
@Raruto Raruto mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Raruto Raruto

Labels
refactoring Anything which could result in a API change
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Raruto @volterra79