Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compdef #22

Merged
merged 1 commit into from
May 1, 2020
Merged

Add compdef #22

merged 1 commit into from
May 1, 2020

Conversation

nguymin4
Copy link
Contributor

@nguymin4 nguymin4 commented May 1, 2020 •
edited
Loading

The compdef was accidentally removed in
0fa9e93#diff-188085b95c22185f0026fe08e980444a

Fix issue #21

@g-plane
Copy link
Owner

g-plane commented May 1, 2020

Have you tested it yet? We should confirm this before merging PR by checking the result.

@nguymin4
Copy link
Contributor Author

nguymin4 commented May 1, 2020 •
edited
Loading

These are screenshots of completions for run and remove commands.
I don't know what was the reason why you removed the compdef

Screenshot from 2020-05-01 15-01-03
Screenshot from 2020-05-01 15-03-49

@g-plane
Copy link
Owner

g-plane commented May 1, 2020

Maybe I've removed it accidentally. Sorry.

Thanks for this PR!

g-plane
g-plane approved these changes May 1, 2020
View reviewed changes
Copy link
Owner

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@g-plane g-plane merged commit 244ca39 into g-plane:master May 1, 2020
@nguymin4 nguymin4 deleted the fix-compdef branch May 1, 2020 13:50
@jedster1111 jedster1111 mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-plane g-plane g-plane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguymin4 @g-plane