fix handling unknown incorrectly (fix #36)

g-plane · Mar 13, 2024 · 9c83bb7 · 9c83bb7
1 parent c005bb2
commit 9c83bb7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fixed handling `unknown` incorrectly. (Fix [#36](https://github.com/g-plane/typed-query-selector/issues/36))
+
 ## v2.11.1
 
 - Fixed for TypeScript 5.4. (Fix [#35](https://github.com/g-plane/typed-query-selector/issues/35))

diff --git a/parser.d.ts b/parser.d.ts
@@ -120,7 +120,9 @@ export type ParseSelector<
   I extends string,
   Fallback extends Element = Element,
 > = ParseSelectorToTagNames<I> extends string
-  ? ExpandAnd<ParseSelectorToTagNames<I>, Fallback>
+  ? ExpandAnd<ParseSelectorToTagNames<I>, Fallback> extends Element
+    ? ExpandAnd<ParseSelectorToTagNames<I>, Fallback>
+    : Fallback
   : Fallback
 
 /**

diff --git a/shim.d.ts b/shim.d.ts
@@ -6,7 +6,7 @@ declare global {
 
     querySelectorAll<S extends string>(
       selector: S,
-    ): NodeListOf<ParseSelector<S> extends Node ? ParseSelector<S> : Node>
+    ): NodeListOf<ParseSelector<S>>
   }
 
   interface Element {