Fix symlink install bug originating from generate_parameter_library_py #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #80 +/- ##
==========================================
- Coverage 33.59% 33.37% -0.23%
==========================================
Files 37 37
Lines 5453 5453
Branches 1251 1251
==========================================
- Hits 1832 1820 -12
- Misses 3559 3572 +13
+ Partials 62 61 -1 ☔ View full report in Codecov by Sentry. |
nspielbau
approved these changes
Apr 25, 2024
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Oberacda
force-pushed
the
fb_fix_symlink_install
branch
from
bf52574
to
c96f625
Compare
nspielbau
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_parameter_library_pydoes not seem to work withpackage_dir = { "": "src/" }insetup.py.This moves the Python package to the top-level package dir to fix this issue.
Closes #79