Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal state machine of action node #63

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Fix internal state machine of action node #63

merged 3 commits into from
Mar 28, 2024

Conversation

Oberacda
Copy link
Contributor

The implicit state machine in the action node was not implemented correctly.
This PR implements the state machine explicitly and fixes the invalid transitions in the previous one.

Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
@Oberacda Oberacda added bug Something isn't working Nodes Issues concerning the standard node library. High Priority labels Mar 23, 2024
@Oberacda Oberacda added this to the First ROS2 Release milestone Mar 23, 2024
@Oberacda Oberacda requested a review from a team March 23, 2024 11:09
@Oberacda Oberacda self-assigned this Mar 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 24.44444% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 33.02%. Comparing base (17e31b8) to head (4d8754c).

Files Patch % Lines
ros_bt_py/src/ros_bt_py/ros_nodes/action.py 24.44% 68 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #63      +/-   ##
==========================================
+ Coverage   32.87%   33.02%   +0.15%     
==========================================
  Files          37       37              
  Lines        5415     5453      +38     
  Branches     1250     1251       +1     
==========================================
+ Hits         1780     1801      +21     
- Misses       3567     3584      +17     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 23, 2024

Test Results

 10 files  ±0   10 suites  ±0   5s ⏱️ ±0s
153 tests ±0  153 ✅ ±0  0 💤 ±0  0 ❌ ±0 
306 runs  ±0  306 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4d8754c. ± Comparison against base commit 17e31b8.

♻️ This comment has been updated with latest results.

Signed-off-by: David Oberacker <[email protected]>
@Oberacda Oberacda requested a review from nspielbau March 25, 2024 08:31
Copy link
Contributor

@nspielbau nspielbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oberacda Oberacda merged commit dd1ed1e into dev Mar 28, 2024
7 checks passed
@Oberacda Oberacda deleted the fix_action_node branch July 4, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority Nodes Issues concerning the standard node library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants