-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal state machine of action node #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Oberacda
added
bug
Something isn't working
Nodes
Issues concerning the standard node library.
High Priority
labels
Mar 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #63 +/- ##
==========================================
+ Coverage 32.87% 33.02% +0.15%
==========================================
Files 37 37
Lines 5415 5453 +38
Branches 1250 1251 +1
==========================================
+ Hits 1780 1801 +21
- Misses 3567 3584 +17
Partials 68 68 ☔ View full report in Codecov by Sentry. |
nspielbau
reviewed
Mar 24, 2024
Signed-off-by: David Oberacker <[email protected]>
nspielbau
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit state machine in the action node was not implemented correctly.
This PR implements the state machine explicitly and fixes the invalid transitions in the previous one.