Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Result types for internal control flow. #137

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Oberacda
Copy link
Contributor

In the current library architecture, errors are managed with Exceptions sent over multiple call hierarchy layers. Similarly, function results need to be used properly. So, I propose a rework to use Rust style Result types using the result package.

@Oberacda Oberacda added enhancement New feature or request help wanted Extra attention is needed Core Library Issues concerning the core BT library. Tests Issues concerning the tests. In Progress Nodes Issues concerning the standard node library. High Priority labels Oct 29, 2024
@Oberacda Oberacda added this to the v0.2.x milestone Oct 29, 2024
@Oberacda Oberacda self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Test Results

 1 files   -   3  1 suites   - 3   2s ⏱️ -54s
16 tests  - 165  0 ✅  - 181  0 💤 ±0  0 ❌ ±0  16 🔥 +16 
16 runs   - 708  0 ✅  - 724  0 💤 ±0  0 ❌ ±0  16 🔥 +16 

For more details on these errors, see this check.

Results for commit c049162. ± Comparison against base commit 27dd929.

This pull request removes 181 and adds 16 tests. Note that renamed tests count towards both.
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_reset[0.05]
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_reset[1.0]
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_shutdown[0.05]
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_shutdown[1.0]
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_success[0.05]
ros_bt_py.tests.nodes.test_wait.TestWait ‑ test_node_success[1.0]
ros_bt_py.tests.nodes.test_wait.TestWaitInput ‑ test_node_reset[0.05]
ros_bt_py.tests.nodes.test_wait.TestWaitInput ‑ test_node_reset[1.0]
ros_bt_py.tests.nodes.test_wait.TestWaitInput ‑ test_node_shutdown[0.05]
ros_bt_py.tests.nodes.test_wait.TestWaitInput ‑ test_node_shutdown[1.0]
…
ros_bt_py ‑ tests.nodes.test_wait
ros_bt_py ‑ tests.ros_nodes.test_enum
ros_bt_py ‑ tests.ros_nodes.test_enum_fields
ros_bt_py ‑ tests.ros_nodes.test_fields_to_message
ros_bt_py ‑ tests.ros_nodes.test_message_from_dict
ros_bt_py ‑ tests.ros_nodes.test_message_from_dict_const
ros_bt_py ‑ tests.ros_nodes.test_message_to_fields
ros_bt_py ‑ tests.ros_nodes.test_ros_param_input
ros_bt_py ‑ tests.ros_nodes.test_ros_param_option
ros_bt_py ‑ tests.ros_nodes.test_ros_param_option_default_input
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Library Issues concerning the core BT library. enhancement New feature or request help wanted Extra attention is needed High Priority In Progress Nodes Issues concerning the standard node library. Tests Issues concerning the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant