-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Result types for internal control flow. #137
Draft
Oberacda
wants to merge
12
commits into
main
Choose a base branch
from
fb_rework_error_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
Oberacda
added
enhancement
New feature or request
help wanted
Extra attention is needed
Core Library
Issues concerning the core BT library.
Tests
Issues concerning the tests.
In Progress
Nodes
Issues concerning the standard node library.
High Priority
labels
Oct 29, 2024
Test Results 1 files - 3 1 suites - 3 2s ⏱️ -54s For more details on these errors, see this check. Results for commit c049162. ± Comparison against base commit 27dd929. This pull request removes 181 and adds 16 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Core Library
Issues concerning the core BT library.
enhancement
New feature or request
help wanted
Extra attention is needed
High Priority
In Progress
Nodes
Issues concerning the standard node library.
Tests
Issues concerning the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current library architecture, errors are managed with Exceptions sent over multiple call hierarchy layers. Similarly, function results need to be used properly. So, I propose a rework to use Rust style Result types using the result package.