Fix bug: unable remove Action node with initial default values #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberacda
approved these changes
Oct 28, 2024
Oberacda
merged commit a642e7f
into
fzi-forschungszentrum-informatik:dev
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: crashing when attempting to remove action node with initial values. #128
Cause: the non-ROS message type int is assigned as the initial value for result and feedback type. When the action node is removed, the output fields are set to
Noneduring_do_shutdown()which fails because the result and feedback type have no fields defined.Solution: Set result and feedback type to ROS message
Int64initially. This works as a temporary solution but is properly fixed and adressed by #23 .