Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues #107

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix various issues #107

merged 3 commits into from
Oct 1, 2024

Conversation

Oberacda
Copy link
Contributor

@Oberacda Oberacda commented Oct 1, 2024

No description provided.

@Oberacda Oberacda added the bug Something isn't working label Oct 1, 2024
@Oberacda Oberacda added this to the ROSCon 2024 milestone Oct 1, 2024
@Oberacda Oberacda self-assigned this Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 49.40%. Comparing base (4531201) to head (32b1295).

Files with missing lines Patch % Lines
ros_bt_py/ros_bt_py/tree_manager.py 17.39% 19 Missing ⚠️
ros_bt_py/ros_bt_py/ros_nodes/action.py 42.85% 4 Missing ⚠️
ros_bt_py/ros_bt_py/tree_node.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #107      +/-   ##
==========================================
+ Coverage   49.18%   49.40%   +0.21%     
==========================================
  Files          58       58              
  Lines        7703     7681      -22     
  Branches     1676     1658      -18     
==========================================
+ Hits         3789     3795       +6     
+ Misses       3850     3822      -28     
  Partials       64       64              
Flag Coverage Δ
49.40% <24.24%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

Test Results

  3 files  ±0    3 suites  ±0   41s ⏱️ ±0s
181 tests ±0  181 ✅ ±0  0 💤 ±0  0 ❌ ±0 
543 runs  ±0  543 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 32b1295. ± Comparison against base commit 4531201.

@Oberacda Oberacda merged commit 0fef933 into dev Oct 1, 2024
9 checks passed
@Oberacda Oberacda deleted the fix_various_issues branch October 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants