Directly show inputs and outputs for Services/Topics/Actions #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Oberacker <[email protected]>
Oberacda
added
enhancement
nspielbau
reviewed
Aug 8, 2024
nspielbau
reviewed
Aug 8, 2024
| node_inputs[field] = type(getattr(msg, field)) | ||
| self.passthrough = False | ||
| else: | ||
| node_inputs["in"] = self.options["service_type"] |
There was a problem hiding this comment.
Does this default make sense? Why would we not fail if the request_type is not a Message Type?
| node_outputs[field] = type(getattr(msg, field)) | ||
| self.passthrough = False | ||
| else: | ||
| node_outputs["out"] = self.options["service_type"] |
Merged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #100 +/- ##
==========================================
- Coverage 50.92% 46.80% -4.12%
==========================================
Files 58 58
Lines 7348 8915 +1567
Branches 1604 2250 +646
==========================================
+ Hits 3742 4173 +431
- Misses 3540 4626 +1086
- Partials 66 116 +50 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services/Topics/Actions get a Request/Response or Message as input or output. This PR changes it so that the fields of the messages are shown directly on the node.