This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Kz faker random wrong output from getCenturyByYear #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use current year to search for century instead of random year.
Codecov Report
@@ Coverage Diff @@
## master #2026 +/- ##
============================================
- Coverage 56.56% 55.86% -0.71%
Complexity 2068 2068
============================================
Files 306 306
Lines 4849 4849
============================================
- Hits 2743 2709 -34
- Misses 2106 2140 +34
Continue to review full report at Codecov.
|
maris-liepins-ermac
changed the title
Loggii
reviewed
Sep 7, 2020
| @@ -183,7 +183,7 @@ class Person extends \Faker\Provider\Person | |||
| */ | |||
| private static function getCenturyByYear($year) | |||
| { | |||
| if ($year >= 2000 && $year <= DateTime::year()) { | |||
| if ($year >= 2000 && $year <= date('Y')) { | |||
There was a problem hiding this comment.
To not run into a future I believe. We don't know why this statement exists, but I believe author know what is it for.
The only thing @maris-liepins-ermac did is switching from "Faker" DateTime with random year output to real DateTime year output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If $year is set to 2001, there is a chance that DateTime::year() will return value less than 2000, which will cause a bug and instead of 21st century will return 20th century. DateTime::year() returns random value.
#2025