Code review

fzaninotto · Jan 4, 2015 · a64991c · GrahamCampbell · Jan 4, 2015 · fzaninotto
1 parent d65354d
commit a64991c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 103 deletions.
diff --git a/src/Faker/Provider/id_ID/Address.php b/src/Faker/Provider/id_ID/Address.php
@@ -313,21 +313,4 @@ public static function buildingNumber()
     {
         return static::numberBetween(1, 999);
     }
-
-    /**
-     * Returns a valid (non-verified) single postal code
-     * @link http://nomor.net/_kodepos.php?_i=provinsi-kodepos&daerah=&jobs=&perhal=200&urut=&asc=000011111&sby=000000&no1=2
-     * @return String Postal Code
-     */
-    // public static function postcode()
-    // {
-    //     // Ended up using the second result on the first page of google search
-    //     // Because the derelict, decrepit, and non user-friendly
-    //     // Official Government site at:
-    //     // http://kodepos.posindonesia.co.id/kodeposalamatindonesialist.php
-    //     // just won't let you list all currently used postal codes
-
-    //     // MAGIC NUMBERS!!!
-    //     return static::numberBetween(10110, 99974);
-    // }
 }
diff --git a/src/Faker/Provider/id_ID/PhoneNumber.php b/src/Faker/Provider/id_ID/PhoneNumber.php
@@ -5,11 +5,8 @@
 class PhoneNumber extends \Faker\Provider\PhoneNumber
 {
     protected static $formats = array(
-        // 8804 234
-        '#######',
-
-        // 7777 4444
-        '########',
+        '#######', // 8804 234
+        '########', // 7777 4444
     );
 
     protected static $internationalPrefixes = array('+62', '(+62)');
@@ -66,14 +63,9 @@ class PhoneNumber extends \Faker\Provider\PhoneNumber
     );
 
     protected static $mobileNumberFormats = array(
-        // 0811 XXX XXX, 10 digits, very old
-        '######',
-
-        // 0811 XXXX XXX, 11 digits
-        '#######',
-
-        // 0811 XXXX XXXX, 12 digits
-        '########',
+        '######',   // 0811 XXX XXX, 10 digits, very old
+        '#######',  // 0811 XXXX XXX, 11 digits
+        '########', // 0811 XXXX XXXX, 12 digits
     );
 
     public static function internationalNumber()

diff --git a/test/Faker/Provider/id_ID/AddressTest.php b/test/Faker/Provider/id_ID/AddressTest.php
diff --git a/test/Faker/Provider/id_ID/PersonTest.php b/test/Faker/Provider/id_ID/PersonTest.php