widget.Table: show first row/column when navigating with keyboard #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
requested changes
Sep 8, 2024
There was a problem hiding this comment.
Thanks so much for fixing this and adding tests.
Unfortunately it only works for when the ID for row or col is 0.
But also we should ensure the focused cell highlight is visible when the cell index is 1 or above, otherwise the indicator hides behind the header until you reach the first row/col
|
I tested by moving too fast, I see the issue now. Will get back to it. |
added 2 commits
September 8, 2024 21:23
The first and last rows may not have been fully put in view if it was first scrolled a bit and then focused via keyboard. This change makes sure thatt ScrollTo and RefreshItem are run even if they are already in focus.
The table size at the focused cell does not need to account for the header's. Fixes 5088.
|
@pierrec can you look at these failures? Because of the force-push it has lost the build history so it is not possible to see where it broke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5088.
Description:
When a Table has its header(s) shown, keyboard navigation fails to show the first row or column
if the list was scrolled. This is because the header size is always added to the offset even when
the first row/column is reached. Disabling this for the first row or column fixes the issue.
Fixes #5088
Checklist: