Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Activity widget :) #4262

Merged
merged 8 commits into from
Sep 23, 2023
Merged

New Activity widget :) #4262

merged 8 commits into from
Sep 23, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Sep 18, 2023 •
edited
Loading

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style and have Since: line.

@coveralls
Copy link

coveralls commented Sep 18, 2023 •
edited
Loading

Coverage Status

coverage: 64.99% (-0.3%) from 65.275% when pulling 735657e on andydotxyz:feature/activity into 066aa79 on fyne-io:develop.

Jacalz
Jacalz requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wasn't expecting OpenGL rendered circles so soon.
Left a few comments inline. Nice to see the square sizes being used as well :)

internal/painter/gl/draw.go Outdated Show resolved Hide resolved
internal/painter/gl/draw.go Outdated Show resolved Hide resolved
widget/activity.go Outdated Show resolved Hide resolved
@Jacalz
Copy link
Member

Jacalz commented Sep 21, 2023

There seems to be some weird Windows compilation failure in the tests?

@andydotxyz andydotxyz requested a review from Jacalz September 21, 2023 21:03
@andydotxyz
Copy link
Member Author

There seems to be some weird Windows compilation failure in the tests?

Rerunning just to be sure

@andydotxyz
Copy link
Member Author

andydotxyz commented Sep 21, 2023 •
edited
Loading

There seems to be some weird Windows compilation failure in the tests?

I think it is somehow this issue golang/go#51007 and golang/go#57455 - but I have no idea how it got triggered...

We are not the only project to note it today: aquasecurity/defsec#1461

@andydotxyz andydotxyz mentioned this pull request Sep 21, 2023
Merged
4 tasks
@andydotxyz andydotxyz merged commit 6686560 into fyne-io:develop Sep 23, 2023
10 of 11 checks passed
@andydotxyz andydotxyz deleted the feature/activity branch September 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz