Mac: Use brew installed sqlite instead of the system one #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mac OS hasn't failed after 3 runs on Travis (Mac OS X). 3 more runs locally. r? @julienw |
| brew install openssl libupnp sqlite | ||
|
|
||
| # openssl and sqlite libraries are already installed on OS X base system. That's | ||
| # why we need to export them explicitely. |
There was a problem hiding this comment.
nit: "that's why we need to explicitely specify the directories that brew installed"
|
Changes Unknown when pulling b9a7f07 on JohanLorenzo:workaround-openssl-failure into * on fxbox:master*. |
|
Changes Unknown when pulling fbcda44 on JohanLorenzo:workaround-openssl-failure into * on fxbox:master*. |
|
r=me ! thx ! |
|
Changes Unknown when pulling 45aec70 on JohanLorenzo:workaround-openssl-failure into * on fxbox:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link #414