Update ci-go-cover.yml #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add triggers: - pull_request - workflow_dispatch Bump Go to 1.20.
Reduce min coverage to 96% (was 98%) since the Diagnose() and DiagnoseFirst() functions reduced code coverage because of error path . These two functions return diagnostic notation for debugging, so CBOR encoding/decoding functions are unaffected (still >= 98% coverage).
fxamacker
approved these changes
May 15, 2023
There was a problem hiding this comment.
Thanks! I had to reduce min coverage to 96% because new Diagnose() and DiagnoseFirst() reduced code coverage due to error path.
These two functions return diagnostic notation for debugging, so we're still at 98% coverage for the CBOR encoding/decoding functions.
Install github.com/x448/[email protected] manually.
Use Go 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #403
@fxamacker The template for PRs should be updated to make CI files considered same way as docs: no signature required by contributor.