Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support diagnostic notation #384

Closed
zensh opened this issue Jan 16, 2023 · 4 comments
Closed

feature: support diagnostic notation #384

zensh opened this issue Jan 16, 2023 · 4 comments

Comments

@zensh
Copy link
Contributor

zensh commented Jan 16, 2023

Is your feature request related to a problem? Please describe.
https://www.rfc-editor.org/rfc/rfc8949.html#name-diagnostic-notation

I would like to make a PR.
@fxamacker
Copy link
Owner

@zensh yes, I think supporting Diagnostic Notation (DN) would be useful, but we should avoid affecting performance of regular CBOR decoding/unmarshalling (ns/op, B/op, and allocs/op).

Please feel free to open PR and maybe include comparison output from benchstat.

BTW, in case you're interested, Appendix G of RFC 8610 defines the Extended Diagnostic Notation, which adds some extensions to DN.

zensh added a commit to ldclabs/cbor that referenced this issue Jan 26, 2023
@zensh
Implements diagnostic notation (fxamacker#384)
78118bc 
Signed-off-by: Yan Qing <[email protected]>
@zensh zensh mentioned this issue Jan 26, 2023
Merged
8 tasks
zensh added a commit to ldclabs/cbor that referenced this issue Mar 20, 2023
@zensh
Implements diagnostic notation (fxamacker#384)
daa9026 
Signed-off-by: Yan Qing <[email protected]>
@zensh
Copy link
Contributor Author

zensh commented Mar 25, 2023

@fxamacker Do you have any other suggestions? I can fix them.

@fxamacker
Copy link
Owner

@zensh The PR is looking good, I reviewed text string encoding today and need to continue reviewing the rest next weekend.

I was asked to take over a project at work and have been working more overtime than usual. And my father passed away this year so my personal time was affected.

The kindness of contributors on this project have been a welcome oasis. Thanks again for your patience and contributions!

zensh added a commit to ldclabs/cbor that referenced this issue May 1, 2023
@zensh
Implements diagnostic notation (fxamacker#384)
a4da8c8 
Signed-off-by: Yan Qing <[email protected]>
fxamacker added a commit that referenced this issue May 14, 2023
@fxamacker
Merge pull request #386 from ldclabs/feature/diagnostic-notation
92d0a5a 
Implements diagnostic notation (#384)
@fxamacker
Copy link
Owner

This is closed by PR #386. Great work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zensh @fxamacker