have 'bazel test' non-test targets depend on --remote_download_output

This fixes bazelbuild#17190 Closes bazelbuild#17195. PiperOrigin-RevId: 501555041 Change-Id: Ie52f72fb82912dde135eaa56c02d9756eb31365b
fweikert · Jan 12, 2023 · e8182ce · e8182ce
1 parent 36a93f9
commit e8182ce
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/remote/ToplevelArtifactsDownloader.java b/src/main/java/com/google/devtools/build/lib/remote/ToplevelArtifactsDownloader.java
@@ -184,9 +184,9 @@ private boolean shouldDownloadToplevelOutputs(ConfiguredTargetKey configuredTarg
           if (configuredTarget instanceof RuleConfiguredTarget) {
             var ruleConfiguredTarget = (RuleConfiguredTarget) configuredTarget;
             var isTestRule = isTestRuleName(ruleConfiguredTarget.getRuleClassString());
-            return !isTestRule;
+            return !isTestRule && downloadToplevel;
           }
-          return true;
+          return downloadToplevel;
         } catch (InterruptedException ignored) {
           Thread.currentThread().interrupt();
           return false;