Re-add StarlarkDefinedAspect.getAttributeAspects

Needed for the new version of Stardoc. Accidentally removed by b21cf25 PiperOrigin-RevId: 518375888 Change-Id: I7927e302bda282ce63b98a9c03f959de6406cdd8
fweikert · Mar 21, 2023 · 6ec2511 · 6ec2511
1 parent 9c01a5a
commit 6ec2511
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkDefinedAspect.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkDefinedAspect.java
@@ -107,6 +107,11 @@ public Optional<String> getDocumentation() {
     return Optional.ofNullable(documentation);
   }
 
+  /** Returns the names of rule attributes along which the aspect will propagate. */
+  public ImmutableList<String> getAttributeAspects() {
+    return attributeAspects;
+  }
+
   public ImmutableList<Attribute> getAttributes() {
     return attributes;
   }

diff --git a/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java
@@ -2021,6 +2021,21 @@ public void declaredProvidersBadTypeForDoc() throws Exception {
         "got value of type 'int', want 'string or NoneType'", "provider(doc = 1)");
   }
 
+  @Test
+  public void aspectAttrs() throws Exception {
+    evalAndExport(
+        ev,
+        "def _impl(target, ctx):", //
+        "   pass",
+        "my_aspect = aspect(_impl, attr_aspects=['srcs', 'data'])");
+
+    StarlarkDefinedAspect myAspect = (StarlarkDefinedAspect) ev.lookup("my_aspect");
+    assertThat(myAspect.getAttributeAspects()).containsExactly("srcs", "data");
+    assertThat(myAspect.getDefinition(AspectParameters.EMPTY).propagateAlong("srcs")).isTrue();
+    assertThat(myAspect.getDefinition(AspectParameters.EMPTY).propagateAlong("data")).isTrue();
+    assertThat(myAspect.getDefinition(AspectParameters.EMPTY).propagateAlong("other")).isFalse();
+  }
+
   @Test
   public void aspectAllAttrs() throws Exception {
     evalAndExport(
@@ -2030,6 +2045,7 @@ public void aspectAllAttrs() throws Exception {
         "my_aspect = aspect(_impl, attr_aspects=['*'])");
 
     StarlarkDefinedAspect myAspect = (StarlarkDefinedAspect) ev.lookup("my_aspect");
+    assertThat(myAspect.getAttributeAspects()).containsExactly("*");
     assertThat(myAspect.getDefinition(AspectParameters.EMPTY).propagateAlong("foo")).isTrue();
   }