Skip to content

Commit

Permalink
python: Remove mention of defunct --python_binary flag
Browse files Browse the repository at this point in the history
This flag has been removed from the Google build, so don't mention it in the
comment as a concern.

PiperOrigin-RevId: 523510796
Change-Id: I4622296895b099ec02bc04adae9ebcdf6b036910
  • Loading branch information
rickeylev authored and copybara-github committed Apr 11, 2023
1 parent b77e8c2 commit 5ab5d80
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions src/main/starlark/builtins_bzl/common/python/py_executable.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -214,19 +214,13 @@ def _get_runtime_details(ctx, semantics):
A struct; see inline-field comments of the return value for details.
"""

# NOTE: Both Bazel and Google have similar legacy "path to a python
# interpreter" flags with similar functions, but with subtle differences.
#
# Bazel has --python_path. This flag has a computed default of "python" when
# its actual default is null (see
# BazelPythonConfiguration.java#getPythonPath). This flag is only used if
# toolchains are not enabled and `--python_top` isn't set.
#
# Google has --python_binary. This flag defaults to null; no special
# computed behavior. If set, it is used instead of any runtime or toolchain.
# This is a legacy behavior, but not fully cleaned up yet.
# toolchains are not enabled and `--python_top` isn't set. Note that Google
# used to have a variant of this named --python_binary, but it has since
# been removed.
#
# TODO(b/230428071): Remove this once Google's --python_binary flag is removed.
# TOOD(bazelbuild/bazel#7901): Remove this once --python_path flag is removed.

if IS_BAZEL:
Expand Down

0 comments on commit 5ab5d80

Please sign in to comment.