Fix crash in BwoB when creating symlink to source files.

Fixes bazelbuild#18321. PiperOrigin-RevId: 529656152 Change-Id: I06c60282893ef57dea837864031da0fe522937b8
fweikert · May 5, 2023 · 03469cc · 03469cc
1 parent c72643c
commit 03469cc
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionFileSystem.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionFileSystem.java
@@ -185,7 +185,10 @@ private void maybeInjectMetadataForSymlinkOrDownload(PathFragment linkPath, Arti
         targetPath.isAbsolute(),
         "non-symlink artifact materialized as symlink must point to absolute path");
 
-    if (inputFetcher.getRemoteOutputChecker().shouldDownloadOutputDuringActionExecution(output)) {
+    if (isOutput(targetPath)
+        && inputFetcher
+            .getRemoteOutputChecker()
+            .shouldDownloadOutputDuringActionExecution(output)) {
       var targetActionInput = getInput(targetPath.relativeTo(execRoot).getPathString());
       if (targetActionInput != null) {
         if (output.isTreeArtifact()) {

diff --git a/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java
@@ -723,6 +723,34 @@ public void downloadToplevel_symlinkFile() throws Exception {
     assertValidOutputFile("foo-link", "foo\n");
   }
 
+  @Test
+  public void downloadToplevel_symlinkSourceFile() throws Exception {
+    // TODO(chiwang): Make metadata for downloaded symlink non-remote.
+    assumeFalse(OS.getCurrent() == OS.WINDOWS);
+
+    setDownloadToplevel();
+    writeSymlinkRule();
+    write(
+        "BUILD",
+        "load(':symlink.bzl', 'symlink')",
+        "symlink(",
+        "  name = 'foo-link',",
+        "  target = ':foo.txt'",
+        ")");
+    write("foo.txt", "foo");
+
+    buildTarget("//:foo-link");
+
+    assertOnlyOutputContent("//:foo-link", "foo-link", "foo" + lineSeparator());
+
+    // Delete link, re-plant symlink
+    getOutputPath("foo-link").delete();
+
+    buildTarget("//:foo-link");
+
+    assertOnlyOutputContent("//:foo-link", "foo-link", "foo" + lineSeparator());
+  }
+
   @Test
   public void downloadToplevel_symlinkTree() throws Exception {
     // TODO(chiwang): Make metadata for downloaded symlink non-remote.