Goto{Desk,Page,DeskAndPage}: use 'screen' keyword #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GotoDesk, GotoPage, and GotoDeskAndPage commands have never followed
other conventions for commands which accept screen-specific
instructioons, by using the literal keyword "screen" to denote the
specific screen.
For example:
EWMHBaseStruts screen HDMI-1 0 0 20 20
Change these commands so that this is the case. This also includes
hard-coded references to commands used by modules, such as FvwmPager.
This is a breaking syntax change.
Fixes #965
ThomasAdam
added
the
type:breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GotoDesk, GotoPage, and GotoDeskAndPage commands have never followed
other conventions for commands which accept screen-specific
instructioons, by using the literal keyword "screen" to denote the
specific screen.
For example:
Change these commands so that this is the case. This also includes
hard-coded references to commands used by modules, such as FvwmPager.
This is a breaking syntax change.