Simplify _NET_WM_NAME setting #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other than the off-by-one, it didn't always NUL-terminate the string being sent, causing issues in programs that expect the window manager name to be NUL-terminated. Spotted after an issue with rofi reported by Mikhail and fixed thanks to Thomas Adam pointing me at the right chunk of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than the off-by-one, it didn't always NUL-terminate the string being sent, causing issues in programs that expect the window manager name to be NUL-terminated.
Spotted after an issue with rofi reported by Mikhail and fixed thanks to Thomas Adam pointing me at the right chunk of code.
Have to admit that I'm still puzzled though, since the previous length of 4 should still result in "FVWM" being set as the WM name, so this change should actually be a no-op, yet I can't make rofi crash anymore.
P.S.: I'm assuming that the last 0x3 was a typo for 0x33 (i.e. '3')