This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[Test Script] Update busybox ping test to run from Jenkins #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
============================================
+ Coverage 32.68% 32.75% +0.06%
- Complexity 1242 1248 +6
============================================
Files 522 522
Lines 13093 13117 +24
Branches 1606 1610 +4
============================================
+ Hits 4279 4296 +17
- Misses 8233 8236 +3
- Partials 581 585 +4
Continue to review full report at Codecov.
|
pkommoju
reviewed
May 3, 2021
pkommoju
reviewed
May 3, 2021
pkommoju
reviewed
May 4, 2021
pkommoju
approved these changes
May 4, 2021
yes, in the test setup readme, we will keep the steps needed to allow the three hosts to seamlessly ssh to each other in order to run the tests. |
xieus
approved these changes
May 5, 2021
|
|
||
| from helper_functions import * | ||
| from termcolor import colored | ||
|
|
||
| def busybox_container_cleanup(ip, con): | ||
| def busybox_container_cleanup(aca_node_ip, con): |
There was a problem hiding this comment.
Like the change as making the parameter explicit.
Btw, con = container? Can we also make a similar change here?
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features to restart ACA on remote nodes before start of test.
All tests being on AWS machines.