Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Route Manager] Fix L3 e2e issues for Neutron Router #599

Merged
merged 18 commits into from
Apr 20, 2021
Merged

[Route Manager] Fix L3 e2e issues for Neutron Router #599

merged 18 commits into from
Apr 20, 2021

Conversation

cj-chung
Copy link
Contributor

@cj-chung cj-chung commented Apr 16, 2021 •
edited
Loading

This PR solve two issues in RM:

  1. Add gateway interface to Neutron Router got vpc_id missing in owner.
  2. Neutron Router didn't bind to any network/vpc.
    We enforce a restriction here. Neutron Router can only attach subnets from the same network.

cj-chung added 14 commits March 3, 2021 10:29
@cj-chung cj-chung requested a review from xieus April 16, 2021 00:24
@cj-chung cj-chung self-assigned this Apr 16, 2021
@xieus xieus added the bug Something isn't working label Apr 17, 2021
@xieus xieus added this to the Version 0.12.2021.04.30 milestone Apr 17, 2021
xieus
xieus reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cj-chung A few quick comments. Should be very easy to fix. Thanks James.

...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/NeutronRouterServiceImpl.java
Comment on lines +124 to +125
throws SpecifyBothSubnetIDAndPortID, ResourceNotFoundException, ResourcePersistenceException, RouterUnavailable,
DatabasePersistenceException, PortIDIsAlreadyExist, PortIsAlreadyInUse, SubnetNotBindUniquePortId, RouterHasMultipleVPCs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice before -- This method throws 9 different exceptions.. @cj-chung

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xieus We can rewrite the error handling part when we refactor the RM's code.

...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/NeutronRouterServiceImpl.java Show resolved Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/NeutronRouterServiceImpl.java Show resolved Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/NeutronRouterServiceImpl.java Show resolved Hide resolved
@cj-chung cj-chung requested a review from xieus April 19, 2021 20:43
xieus
xieus approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xieus xieus merged commit 0a58676 into futurewei-cloud:master Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xieus xieus xieus approved these changes

Assignees

@cj-chung cj-chung

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.14.2021.04.30
Development

Successfully merging this pull request may close these issues.
2 participants
@cj-chung @xieus