Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Documentation] Message Queue Design #544

Merged
merged 11 commits into from
Mar 1, 2021
Merged

Conversation

issacyxw
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #544 (6a803c1) into master (17226df) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #544   +/-   ##
=========================================
  Coverage     35.20%   35.21%           
  Complexity     1234     1234           
=========================================
  Files           491      491           
  Lines         12157    12157           
  Branches       1545     1545           
=========================================
+ Hits           4280     4281    +1     
+ Misses         7303     7302    -1     
  Partials        574      574           
Impacted Files Coverage Δ Complexity Δ
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17226df...6a803c1. Read the comment docs.

@xieus xieus changed the title MQdesign adoc [Documentation] Message Queue Design Feb 25, 2021
@xieus xieus self-requested a review February 25, 2021 06:26
@xieus xieus added the documentation Improvements or additions to documentation label Feb 25, 2021
@xieus xieus added this to the Version 1.0.2021.02.28 milestone Feb 25, 2021
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please take a look at the comments, mostly minor.

@@ -23,25 +25,68 @@ NOTE: This document is under development

[#system-requirements]
== System Requirements
1. DPM can split the network configuration into multiple goal states. DPM can appropriately choose MQ or GRPC channel to send goal state to the corresponding ACA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /tab. Please go through the entire doc, and replace tab with blank.

@@ -23,25 +25,68 @@ NOTE: This document is under development

[#system-requirements]
== System Requirements
1. DPM can split the network configuration into multiple goal states. DPM can appropriately choose MQ or GRPC channel to send goal state to the corresponding ACA.
2. When ACA configures goal state successfully, it returns success reply. When DPM receives replies of all goal states for a network configuration, it returns successful configuration to the caller
3. Messaging services can support 1000,000 data plane nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data plane nodes => compute nodes


===== MQ topic subscription or unsubscription
image::MQsubscribe.png[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image appears to very large. Can you check Can you check https://github.com/issacyxw/alcor/blob/master/docs/modules/ROOT/pages/mq_services/message_queue_system.adoc and adjust the size?

@xieus xieus self-requested a review March 1, 2021 22:43
@xieus xieus merged commit c51a7b4 into futurewei-cloud:master Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants