-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=========================================
Coverage 35.20% 35.21%
Complexity 1234 1234
=========================================
Files 491 491
Lines 12157 12157
Branches 1545 1545
=========================================
+ Hits 4280 4281 +1
+ Misses 7303 7302 -1
Partials 574 574
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please take a look at the comments, mostly minor.
@@ -23,25 +25,68 @@ NOTE: This document is under development | |||
|
|||
[#system-requirements] | |||
== System Requirements | |||
1. DPM can split the network configuration into multiple goal states. DPM can appropriately choose MQ or GRPC channel to send goal state to the corresponding ACA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove /tab. Please go through the entire doc, and replace tab with blank.
@@ -23,25 +25,68 @@ NOTE: This document is under development | |||
|
|||
[#system-requirements] | |||
== System Requirements | |||
1. DPM can split the network configuration into multiple goal states. DPM can appropriately choose MQ or GRPC channel to send goal state to the corresponding ACA. | |||
2. When ACA configures goal state successfully, it returns success reply. When DPM receives replies of all goal states for a network configuration, it returns successful configuration to the caller | |||
3. Messaging services can support 1000,000 data plane nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data plane nodes => compute nodes
|
||
===== MQ topic subscription or unsubscription | ||
image::MQsubscribe.png[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image appears to very large. Can you check Can you check https://github.com/issacyxw/alcor/blob/master/docs/modules/ROOT/pages/mq_services/message_queue_system.adoc and adjust the size?
No description provided.