Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Make changes according to the suggestions of the review #519

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

chenpiaoping
Copy link
Contributor

No description provided.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry to merge #515 too early :-)

@codecov-io
Copy link

Codecov Report

Merging #519 (780b9ac) into master (28cfda5) will decrease coverage by 0.57%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #519      +/-   ##
============================================
- Coverage     35.72%   35.14%   -0.58%     
+ Complexity     1163     1150      -13     
============================================
  Files           468      469       +1     
  Lines         11318    11384      +66     
  Branches       1456     1464       +8     
============================================
- Hits           4043     4001      -42     
- Misses         6723     6842     +119     
+ Partials        552      541      -11     
Impacted Files Coverage Δ Complexity Δ
...alcor/portmanager/processor/FixedIpsProcessor.java 69.73% <ø> (-0.14%) 41.00 <0.00> (ø)
...ewei/alcor/portmanager/processor/MacProcessor.java 91.93% <ø> (-1.72%) 12.00 <0.00> (-1.00)
.../portmanager/processor/SecurityGroupProcessor.java 81.42% <ø> (-0.27%) 17.00 <0.00> (ø)
...alcor/portmanager/proxy/DataPlaneManagerProxy.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...turewei/alcor/portmanager/repo/PortRepository.java 45.00% <0.00%> (-20.57%) 28.00 <0.00> (ø)
...ortmanager/request/CreateNetworkConfigRequest.java 70.00% <ø> (ø) 3.00 <0.00> (ø)
...ortmanager/request/DeleteNetworkConfigRequest.java 70.00% <ø> (ø) 3.00 <0.00> (ø)
...ortmanager/request/UpdateNetworkConfigRequest.java 77.77% <ø> (ø) 3.00 <0.00> (ø)
...tmanager/rollback/CreateNetworkConfigRollback.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tmanager/rollback/DeleteNetworkConfigRollback.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488e422...780b9ac. Read the comment docs.

@xieus xieus added the enhancement New feature or request label Dec 18, 2020
@xieus xieus merged commit 0f3f99d into futurewei-cloud:master Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants