Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Enhancement] Verify Project Id for DB query #502

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

Gzure
Copy link
Contributor

@Gzure Gzure commented Dec 3, 2020

Verify project id in DB query when no token is passed to Alcor microservices.

@Gzure Gzure linked an issue Dec 3, 2020 that may be closed by this pull request
@xieus xieus requested review from xieus and chenpiaoping December 3, 2020 06:52
@xieus xieus added the enhancement New feature or request label Dec 3, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Dec 3, 2020
@xieus xieus changed the title [Enhancement]verify project id in DB query [Enhancement] Verify Project Id for DB query Dec 3, 2020
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #502 (6728d10) into master (eb9f2ff) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #502      +/-   ##
============================================
- Coverage     35.64%   35.62%   -0.02%     
+ Complexity     1161     1160       -1     
============================================
  Files           467      467              
  Lines         11311    11311              
  Branches       1456     1456              
============================================
- Hits           4032     4030       -2     
- Misses         6723     6724       +1     
- Partials        556      557       +1     
Impacted Files Coverage Δ Complexity Δ
...alcor/portmanager/util/RestParameterValidator.java 41.53% <0.00%> (-3.08%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9f2ff...6728d10. Read the comment docs.

@xieus xieus merged commit df4df67 into futurewei-cloud:master Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Need to verify project id in DB query
3 participants