This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[Hotfix] Fix Issue that gRPC Client and Pulsar Client Can't Coexist #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
changed the title
VanderChen
approved these changes
Dec 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
=========================================
Coverage 35.64% 35.65%
Complexity 1161 1161
=========================================
Files 467 467
Lines 11311 11311
Branches 1456 1456
=========================================
+ Hits 4032 4033 +1
+ Misses 6723 6722 -1
Partials 556 556
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By design, Data-plane Manager should allow multiple data plane clients coexist so that we could enable gRPC fast path and MQ scaling path simultaneously. This PR fixes the issue that DPM can't start (commit a893709) when two types of clients were enabled at the same time.