Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Contract] Add default_routing_table to Router Configuration #479

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

er1cthe0ne
Copy link
Contributor

This minor contract change includes:

  1. added default_routing_table to router configuration - to support the current subnet manager and router design.
  2. change from AuxGateway_type to aux_gateway_type in AuxGateway message - proto3 changes upper case field name to lower case during .proto file compile, so the change is to make this field explicitly to lower case and makes it pretty.

@er1cthe0ne er1cthe0ne added the contract new or modified service interfaces label Nov 17, 2020
@er1cthe0ne er1cthe0ne self-assigned this Nov 17, 2020
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xieus xieus changed the title [Contract] added default_routing_table to router configuration [Contract] Add default_routing_table to Router Configuration Nov 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #479 (aeeb7df) into master (456d800) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #479      +/-   ##
============================================
- Coverage     36.59%   36.59%   -0.01%     
  Complexity     1162     1162              
============================================
  Files           453      453              
  Lines         10869    10869              
  Branches       1393     1393              
============================================
- Hits           3978     3977       -1     
- Misses         6349     6350       +1     
  Partials        542      542              
Impacted Files Coverage Δ Complexity Δ
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.53% <0.00%> (-0.28%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456d800...aeeb7df. Read the comment docs.

@xieus xieus merged commit 6e66bab into futurewei-cloud:master Nov 17, 2020
@er1cthe0ne er1cthe0ne deleted the schema/router branch January 6, 2021 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contract new or modified service interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants