Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Port Mgr] Fix L3 Routing Issues for Unassociated Subnets #454

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[Port Mgr] Fix L3 Routing Issues for Unassociated Subnets #454

merged 2 commits into from
Oct 29, 2020

Conversation

xieus
Copy link
Contributor

@xieus xieus commented Oct 28, 2020 •
edited
Loading

This PR fixes two issues for L3 routing in PM

  • Issue 1: Empty router may be passed down when subnet is not associated to a router
  • Issue 2: In the scenario of mixing subnets with and without association to the router, PM may recognize the new port as a neighbor and put itself in the neighbor table

@xieus xieus added the bug Something isn't working label Oct 28, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Oct 28, 2020
@xieus xieus self-assigned this Oct 28, 2020
cj-chung
cj-chung approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus changed the title [Port Mgr] Fix L3 Routing Issues when Subnets are not Associated with Routers [Port Mgr] Fix L3 Routing Issues for Unassociated Subnets Oct 29, 2020
@xieus xieus merged commit e09d070 into futurewei-cloud:master Oct 29, 2020
@xieus xieus deleted the fix/pm branch October 29, 2020 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cj-chung cj-chung cj-chung approved these changes

@chenpiaoping chenpiaoping Awaiting requested review from chenpiaoping

Assignees

@xieus xieus

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.10.2020.11.30
Development

Successfully merging this pull request may close these issues.
2 participants
@xieus @cj-chung