This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[E2E Integration] Fix Multiple Issues in E2E Integration #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
suggested changes
Oct 28, 2020
...ces/subnet_manager/src/main/java/com/futurewei/alcor/subnet/controller/SubnetController.java
Show resolved
Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/route/service/Impl/NeutronRouterServiceImpl.java
Outdated
Show resolved
Hide resolved
xieus
approved these changes
Oct 28, 2020
...net_manager/src/main/java/com/futurewei/alcor/subnet/service/implement/SubnetServiceImp.java
Outdated
Show resolved
Hide resolved
...ces/subnet_manager/src/main/java/com/futurewei/alcor/subnet/controller/SubnetController.java
Show resolved
Hide resolved
xieus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple issues in e2e integration. The details of issues are described as follows:
Descriptions
Issue 1 - When deleting the subnet, we need to delete the corresponding binding subnet_id in vpc. If the process throws an exception, the exception type is unsupported 500。
Issue 2 - When calling getRulesBySubnetId API in RouteController, the routes in RoutesWebJson returned may be null。
Issue 3 - In the addAnInterfaceToNeutronRouter API in NeutronRouter, if validate router = null, router_id will still be attached in the subnet。
Issue 4 - Delete subnet shows success, but it did not actually succeed，because we lack the database operation of delete subnet in some reasons.
Solutions
Issue 1 solution: Change the HTTP exception type of SubnetIdIsNull to 412.
Issue 2 solution: If routes is null, return new RoutesWebJson(new ArrayList<>()).
Issue 3 solution: Put the steps of verifying router_id before subnet related operations.
Issue 4 solution: Increase the database operation of delete subnet.