Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Compatibility] Make Subnet Entity OpenStack Compatible #438

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

kevin-zhonghao
Copy link
Contributor

@kevin-zhonghao kevin-zhonghao commented Oct 20, 2020

Issue Decription
Openstack subnet show got error: 'NoneType' object is not iterable.
Using Openstack horizon to show subnet also got
Danger: An error occurred. Please try again later.

Solution

  1. Modify AllocationPool.class:
    @JsonProperty("start_ip") -> @JsonProperty("start")
    @JsonProperty("end_ip") -> @JsonProperty("end")

  2. Add configuration of default value in creation of subnet.

@xieus xieus requested a review from cj-chung October 20, 2020 00:17
@xieus xieus added the bug Something isn't working label Oct 20, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Oct 20, 2020
@xieus xieus linked an issue Oct 20, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #438 into master will increase coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
+ Coverage     36.78%   36.88%   +0.10%     
- Complexity     1149     1153       +4     
============================================
  Files           447      447              
  Lines         10706    10722      +16     
  Branches       1367     1371       +4     
============================================
+ Hits           3938     3955      +17     
+ Misses         6233     6231       -2     
- Partials        535      536       +1     
Impacted Files Coverage Δ Complexity Δ
...rewei/alcor/subnet/utils/SubnetManagementUtil.java 21.80% <75.00%> (+7.27%) 5.00 <0.00> (ø)
...rewei/alcor/portmanager/processor/PortContext.java 69.09% <0.00%> (+1.81%) 23.00% <0.00%> (+1.00%)
...alcor/portmanager/util/RestParameterValidator.java 44.61% <0.00%> (+3.07%) 14.00% <0.00%> (+1.00%)
...i/alcor/portmanager/processor/RouterProcessor.java 84.37% <0.00%> (+6.25%) 10.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b92c61...56fccac. Read the comment docs.

@xieus xieus changed the title Fix Openstack subnet issue #428 [Compatibility] Make Subnet Entity OpenStack Compatible Oct 20, 2020
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus merged commit 5e94af8 into futurewei-cloud:master Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openstack subnet show got error "'NoneType' object is not iterable"
4 participants