This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[Compatibility] Make Subnet Entity OpenStack Compatible #438
Merged
xieus
merged 7 commits into
futurewei-cloud:master
from
kevin-zhonghao:fix/subnet_issues
Oct 21, 2020
Merged
[Compatibility] Make Subnet Entity OpenStack Compatible #438
xieus
merged 7 commits into
futurewei-cloud:master
from
kevin-zhonghao:fix/subnet_issues
Oct 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieus
approved these changes
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
+ Coverage 36.78% 36.88% +0.10%
- Complexity 1149 1153 +4
============================================
Files 447 447
Lines 10706 10722 +16
Branches 1367 1371 +4
============================================
+ Hits 3938 3955 +17
+ Misses 6233 6231 -2
- Partials 535 536 +1
Continue to review full report at Codecov.
|
xieus
changed the title
Fix Openstack subnet issue #428
[Compatibility] Make Subnet Entity OpenStack Compatible
Oct 20, 2020
cj-chung
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Decription
Openstack subnet show got error: 'NoneType' object is not iterable.
Using Openstack horizon to show subnet also got
Danger: An error occurred. Please try again later.
Solution
Modify AllocationPool.class:
@JsonProperty("start_ip") -> @JsonProperty("start")
@JsonProperty("end_ip") -> @JsonProperty("end")
Add configuration of default value in creation of subnet.